Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aoflux for UFS #452

Merged
merged 9 commits into from
Jun 24, 2024
Merged

Fix aoflux for UFS #452

merged 9 commits into from
Jun 24, 2024

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Apr 11, 2024

Adds required fields to the ufs FldsExchange and checks for rainc being associated in med_phases_aoflux_mod.

fixes #448

DeniseWorthen and others added 4 commits March 12, 2024 14:11
…A-EMC#115)


* add cpl_scalar for tiled grids, other minor fixes
* add new cpl_scalar for mediator history files for tiled gridded domains
* remove unnecessary trims, fix minor typos and indentation
* set ntile=0 when ntile scalar doesn't exist
* modify dstmask for lnd->atm in UFS


Co-authored-by: uturuncoglu <[email protected]>
@uturuncoglu
Copy link
Collaborator

@DeniseWorthen I was also discussing these with @jedwards4b and it seems that there are some development in NOAA-EMC side related with this issue that is not pushed to ESCOMP yet. Please see following links,

call fldbun_getfldptr(fldbun_a, 'Faxa_rainc', aoflux_in%rainc, xgrid=xgrid, rc=rc)

https://github.com/NOAA-EMC/CMEPS/blob/4e19850cb083bc474b7cde5dc2f8506ec74cc442/mediator/med_phases_aofluxes_mod.F90#L1600C1-L1603C14

@uturuncoglu
Copy link
Collaborator

@DeniseWorthen I think this PR aims to fix those issues and update ESCOMP. Right? I was also looking to this but maybe you already done it. Let me know if you need help.

@DeniseWorthen
Copy link
Collaborator Author

@uturuncoglu Moving the rainc inside the add_gusts was added by you in 64e1c27. But at the top of main at ESCOMP, it is no longer under an add_gusts conditional

call fldbun_getfldptr(fldbun_a, 'Sa_shum', aoflux_in%shum, xgrid=xgrid, rc=rc)
if (chkerr(rc,__LINE__,u_FILE_u)) return
call fldbun_getfldptr(fldbun_a, 'Faxa_rainc', aoflux_in%rainc, xgrid=xgrid, rc=rc)
if (chkerr(rc,__LINE__,u_FILE_u)) return

@uturuncoglu
Copy link
Collaborator

@DeniseWorthen Okay. It seems that it is removed with other PR. Right? @jedwards4b Do you know why? Was it creating issue with CESM?

@uturuncoglu
Copy link
Collaborator

@DeniseWorthen @jedwards4b As I remember we are testing all the PR with CESM.

@DeniseWorthen
Copy link
Collaborator Author

DeniseWorthen commented Apr 11, 2024

@uturuncoglu I was testing Jim's alarm fix branch and found that it failed for UFS, because of the change in the aoflux that was in main. This may not be the optimal way of fixing aoflux from CESM's perspective, but I can at least run Jim's alarm fix branch if I include these changes.

@DeniseWorthen
Copy link
Collaborator Author

@uturuncoglu @jedwards4b I was able to test your PR #447 if I also merged in this fix. All tests passed for UFS. Let me know how you want to proceed---if these changes work for CESM or you need a different fix.

@DeniseWorthen
Copy link
Collaborator Author

@jedwards4b I've tested this PR again w/ UFS and it passes all our tests. Thanks.

@jedwards4b
Copy link
Collaborator

Thank you @DeniseWorthen I'm not going to be able to get to this until after the CESM meeting next week, but I'll make it a high priority then.

@DeniseWorthen
Copy link
Collaborator Author

@jedwards4b I realized there was a much simpler fix for UFS than I initially thought, requiring only a single change in the med_phases_aoflux module. The remaining required changes can go into our UFS fldsExchange.

@jedwards4b jedwards4b merged commit e84e8a1 into ESCOMP:main Jun 24, 2024
2 checks passed
@jedwards4b jedwards4b deleted the bugfix/aoflux4ufs branch June 24, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trouble w/ the gust variables
4 participants