-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aoflux for UFS #452
Fix aoflux for UFS #452
Conversation
…A-EMC#115) * add cpl_scalar for tiled grids, other minor fixes * add new cpl_scalar for mediator history files for tiled gridded domains * remove unnecessary trims, fix minor typos and indentation * set ntile=0 when ntile scalar doesn't exist * modify dstmask for lnd->atm in UFS Co-authored-by: uturuncoglu <[email protected]>
@DeniseWorthen I was also discussing these with @jedwards4b and it seems that there are some development in NOAA-EMC side related with this issue that is not pushed to ESCOMP yet. Please see following links, CMEPS/mediator/med_phases_aofluxes_mod.F90 Line 1604 in 3b1e50b
|
@DeniseWorthen I think this PR aims to fix those issues and update ESCOMP. Right? I was also looking to this but maybe you already done it. Let me know if you need help. |
@uturuncoglu Moving the rainc inside the CMEPS/mediator/med_phases_aofluxes_mod.F90 Lines 1602 to 1605 in 3b1e50b
|
@DeniseWorthen Okay. It seems that it is removed with other PR. Right? @jedwards4b Do you know why? Was it creating issue with CESM? |
@DeniseWorthen @jedwards4b As I remember we are testing all the PR with CESM. |
@uturuncoglu I was testing Jim's alarm fix branch and found that it failed for UFS, because of the change in the aoflux that was in main. This may not be the optimal way of fixing aoflux from CESM's perspective, but I can at least run Jim's alarm fix branch if I include these changes. |
@uturuncoglu @jedwards4b I was able to test your PR #447 if I also merged in this fix. All tests passed for UFS. Let me know how you want to proceed---if these changes work for CESM or you need a different fix. |
@jedwards4b I've tested this PR again w/ UFS and it passes all our tests. Thanks. |
Thank you @DeniseWorthen I'm not going to be able to get to this until after the CESM meeting next week, but I'll make it a high priority then. |
@jedwards4b I realized there was a much simpler fix for UFS than I initially thought, requiring only a single change in the med_phases_aoflux module. The remaining required changes can go into our UFS fldsExchange. |
Adds required fields to the ufs FldsExchange and checks for rainc being associated in
med_phases_aoflux_mod
.fixes #448